Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom builder with default executeBrowserBuilder implementation breaks differential loading #16098

Open
JulianH opened this issue Nov 7, 2019 · 0 comments

Comments

@JulianH
Copy link

@JulianH JulianH commented Nov 7, 2019

馃悶 Bug report

Command

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Migrating a custom builder to Angular8 introduced the problem, which was in the 7.x builder api not present.

Description

When adding a custom builder, the differential loading is broken as the build will not generate the right bundle file names.

The custom builder is just using the default implementation of @angular-devkit/build-angular:browser and i dont identify the problem with that approach.

When ng build --prod is used to generate the bundle, then the output is:

chunk {0} runtime.edb2fcf2778e7bf1d426.js (runtime) 1.45 kB [entry] [rendered]
chunk {0} runtime.edb2fcf2778e7bf1d426.js (runtime) 1.45 kB [entry] [rendered]
chunk {2} polyfills.3c79a0eafef8c32a399a.js (polyfills) 36.4 kB [initial] [rendered]
chunk {2} polyfills.3c79a0eafef8c32a399a.js (polyfills) 38.1 kB [initial] [rendered]
chunk {1} main.e81576bad8e4028b19af.js (main) 169 kB [initial] [rendered]
chunk {1} main.e81576bad8e4028b19af.js (main) 188 kB [initial] [rendered]
chunk {3} styles.3ff695c00d717f2d2a11.css (styles) 0 bytes [initial] [rendered]
Date: 2019-11-07T11:34:50.482Z - Hash: 5233111784167bf895ea - Time: 18447ms

As you can see, the es5 and es2015 suffixes of the chunk names are missing.

馃敩 Minimal Reproduction

I've added a 2nd commit which introduce the custom browser-builder. That custom builder is just calling the default implementation: executeBrowserBuilder.

馃實 Your Environment


     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / 鈻 \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    
Angular CLI: 8.3.17
Node: 10.13.0
OS: win32 x64
Angular: 8.2.13
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.17
@angular-devkit/build-angular     0.803.17
@angular-devkit/build-optimizer   0.803.17
@angular-devkit/build-webpack     0.803.17
@angular-devkit/core              8.3.17
@angular-devkit/schematics        8.3.17
@angular/cli                      8.3.17
@ngtools/webpack                  8.3.17
@schematics/angular               8.3.17
@schematics/update                0.803.17
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.