Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy + Support XTB load translations parser in v9 #16100

Closed
elvisbegovic opened this issue Nov 7, 2019 · 1 comment 路 Fixed by #16111

Comments

@elvisbegovic
Copy link
Contributor

@elvisbegovic elvisbegovic commented Nov 7, 2019

馃殌 Feature request

Command (mark with an x)

- [x] build
- [x] serve

Description

With IVY add support xtb_translation_parser

Describe the solution you'd like

I think ? in xtb_translation_parser.ts#L62 add:

xtb: new (await Promise.resolve().then(() => require(
// @ts-ignore
// tslint:disable-next-line:trailing-comma
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xtb_translation_parser'))).XtbTranslationParser()

Anything else relevant?
Maybe at the moment xtb parser is not ready (@petebacondarwin ?) Because after hack locally and after my app build finish, I get warnings that almost all translations with interpolations are not translated:
xtb

A lot of them are duplicated

/cc @filipesilva

@petebacondarwin

This comment has been minimized.

Copy link
Member

@petebacondarwin petebacondarwin commented Nov 7, 2019

The i18Format needs to line up because we use a legacy mode if xliff that converts ids to xliff, which might be causing the misses...

@vikerman vikerman modified the milestones: v9-candidates, v9-blockers Nov 7, 2019
clydin added a commit to clydin/angular-cli that referenced this issue Nov 8, 2019
mgechev added a commit that referenced this issue Nov 12, 2019
mgechev added a commit that referenced this issue Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.