Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Update to v9 does not include the changes in i18n #16327

Closed
Karasuni opened this issue Dec 1, 2019 · 0 comments 路 Fixed by StephenFluin/angular-update-guide#50
Closed

Angular Update to v9 does not include the changes in i18n #16327

Karasuni opened this issue Dec 1, 2019 · 0 comments 路 Fixed by StephenFluin/angular-update-guide#50

Comments

@Karasuni
Copy link

@Karasuni Karasuni commented Dec 1, 2019

馃悶 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

N/A

Description

The upgrade function and guide does not include the breaking changes in localization. I expect this to be mentioned in the guide ('checkbox I use i18n') and/or to be automatically configured along with the other breaking changes from 8 to 9.

馃敩 Minimal Reproduction

  1. Create an angular 8 workspace: ng new
  2. Add ngx-translate: npm install @ngx-translate/core --save
  3. Follow the steps to upgrade from angular 8 to angular 9: https://update.angular.io/#8.0:9.0
  4. Run the project and observe the error below

馃敟 Exception or Error

core.js:31686 Uncaught Error: It looks like your application or one of its dependencies is using i18n.
Angular 9 introduced a global `$localize()` function that needs to be loaded.
Please run `ng add @angular/localize` from the Angular CLI.
(For non-CLI projects, add `import '@angular/localize/init';` to your `polyfills.ts` file.
For server-side rendering applications add the import to your `main.server.ts` file.)

馃實 Your Environment

Angular CLI: 9.0.0-rc.4
Node: 13.0.1
OS: linux x64

Angular: 9.0.0-rc.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-rc.4
@angular-devkit/build-angular     0.900.0-rc.4
@angular-devkit/build-optimizer   0.900.0-rc.4
@angular-devkit/build-webpack     0.900.0-rc.4
@angular-devkit/core              9.0.0-rc.4
@angular-devkit/schematics        9.0.0-rc.4
@angular/fire                     5.2.3
@ngtools/webpack                  9.0.0-rc.4
@schematics/angular               9.0.0-rc.4
@schematics/update                0.900.0-rc.4
rxjs                              6.5.3
typescript                        3.6.4
webpack                           4.41.2

Anything else relevant?

@alan-agius4 alan-agius4 added this to the v9-blockers milestone Dec 1, 2019
@ngbot ngbot bot removed this from the v9-blockers milestone Dec 1, 2019
@alan-agius4 alan-agius4 added this to the v9-blockers milestone Dec 1, 2019
@ngbot ngbot bot removed this from the v9-blockers milestone Dec 1, 2019
@ngbot ngbot bot added this to the Backlog milestone Dec 1, 2019
@alan-agius4 alan-agius4 removed this from the Backlog milestone Dec 1, 2019
@ngbot ngbot bot added this to the Backlog milestone Dec 1, 2019
@alan-agius4 alan-agius4 modified the milestones: Backlog, v9-blockers Dec 1, 2019
@alan-agius4 alan-agius4 self-assigned this Dec 2, 2019
alan-agius4 added a commit to alan-agius4/angular-update-guide that referenced this issue Dec 2, 2019
alan-agius4 added a commit to alan-agius4/angular-update-guide that referenced this issue Dec 4, 2019
StephenFluin added a commit to StephenFluin/angular-update-guide that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.