Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics - visit function performance #20079

Open
1 task done
Brocco opened this issue Feb 17, 2021 · 2 comments
Open
1 task done

Schematics - visit function performance #20079

Brocco opened this issue Feb 17, 2021 · 2 comments
Labels
area: devkit/schematics feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature severity4: memory/performance
Milestone

Comments

@Brocco
Copy link
Contributor

Brocco commented Feb 17, 2021

馃殌 Feature request

Command (mark with an x)

  • schematics

Description

The tree and directory in schematics allow you to visit each file in that tree/dir, and the handler function runs on each file in series which can be time consuming.

Describe the solution you'd like

Implement a concurrent version of visit that would allow multiple files to be processed at the same time. This solution can be done in addition to visit via visitConcurrent or visitAsync.

The number of concurrent handlers would be handled via an argument and therefore controlled by the consumer.

Also this would likely be handled via RxJS so an observable should be returned by the new visit____ function.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@alan-agius4 alan-agius4 added area: devkit/schematics feature Issue that requests a new feature labels Feb 18, 2021
@ngbot ngbot bot modified the milestone: Backlog Feb 18, 2021
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Feb 1, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 1, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 21, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors and removed feature: votes required Feature request which is currently still in the voting phase labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: devkit/schematics feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature severity4: memory/performance
Projects
None yet
Development

No branches or pull requests

3 participants
@Brocco @alan-agius4 and others