Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github pages deploy create wrong base href for repos with camelcase names #3146

Closed
aj8k opened this issue Nov 15, 2016 · 4 comments
Closed
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@aj8k
Copy link

aj8k commented Nov 15, 2016

Ubuntu 16.04
angular-cli: 1.0.0-beta.19-3

  1. Create repo with name like this: someRepo
  2. ng github-pages:deploy
  3. Base href will be /some-repo, not /someRepo as was expected.
@filipesilva filipesilva added command: deploy P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix labels Nov 21, 2016
@rolyatsats
Copy link
Contributor

The ng github-pages:deploy command derives baseHref from packageName, which is pulled from package.json.

package.json is created through ember-cli/lib/models/blueprint.js which uses the normalizeEntityName function to dasherize as they call it.

There must be a way to override the normalizeEntityName function to support camelCase.

@WebDesignerKits
Copy link

WebDesignerKits commented Dec 28, 2016

This also creates a problem for github pages that use custom domains.

In which case the base href needs to default back to just "/" and no longer the name of the repo, or "/some-repo".

Because unlike the github page, which serves content from: some-account.github.io/some-repo
A custom domain no longer has the extra file path ie, not this: myWebsite.com/some-repo

Instead it servers from myWebsite.com, and so it needs a "/" base href.

Right now the solution is: ng github-pages:deploy --base-href /

@filipesilva
Copy link
Contributor

Closed via #4385.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

4 participants