From ce5686cff91ea9f054cd01c0e2a4f0bddc410f95 Mon Sep 17 00:00:00 2001 From: Filipe Silva Date: Wed, 10 Oct 2018 16:53:03 +0100 Subject: [PATCH] fix(@angular-devkit/build-angular): dont serve files on cwd --- .../build_angular/src/dev-server/index.ts | 1 + .../test/dev-server/works_spec_large.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/packages/angular_devkit/build_angular/src/dev-server/index.ts b/packages/angular_devkit/build_angular/src/dev-server/index.ts index b925b71a62ea..893e04e00626 100644 --- a/packages/angular_devkit/build_angular/src/dev-server/index.ts +++ b/packages/angular_devkit/build_angular/src/dev-server/index.ts @@ -227,6 +227,7 @@ export class DevServerBuilder implements Builder { disableHostCheck: options.disableHostCheck, publicPath: servePath, hot: options.hmr, + contentBase: false, }; if (options.ssl) { diff --git a/packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts b/packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts index 6c62967f007a..f6984ed88b3e 100644 --- a/packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts +++ b/packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts @@ -34,4 +34,16 @@ describe('Dev Server Builder', () => { take(1), ).toPromise().then(done, done.fail); }, 30000); + + it(`doesn't serve files on the cwd directly`, async () => { + const res = await runTargetSpec(host, devServerTargetSpec).pipe( + tap((buildEvent) => expect(buildEvent.success).toBe(true)), + // When webpack-dev-server doesn't have `contentBase: false`, this will serve the repo README. + concatMap(() => from(request('http://localhost:4200/README.md'))), + take(1), + ).toPromise(); + + expect(res).not.toContain('This file is automatically generated during release.'); + expect(res).toContain('HelloWorldApp'); + }); });