New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine grain optimization #13116

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alan-agius4
Collaborator

alan-agius4 commented Dec 3, 2018

We can now enabled/disabled optimisations for scripts and styles.

Ex:

 optimization: {
   scripts: true,
   styles: false,
 },

@alan-agius4 alan-agius4 requested a review from clydin Dec 3, 2018

@googlebot googlebot added the cla: yes label Dec 3, 2018

@alan-agius4 alan-agius4 requested a review from filipesilva Dec 3, 2018

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fine_grain_optimization branch from 94d0069 to afc69ba Dec 3, 2018

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fine_grain_optimization branch 2 times, most recently from 4e2105e to e3e0514 Dec 3, 2018

@@ -214,13 +231,13 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
htmlAcceptHeaders: ['text/html', 'application/xhtml+xml'],
} as WebpackDevServer.HistoryApiFallbackConfig,
stats: false,
compress: browserOptions.optimization,
compress: styles || scripts,

This comment has been minimized.

@alan-agius4

alan-agius4 Dec 3, 2018

Collaborator

Not sure, why this is not always true

This comment has been minimized.

@filipesilva

filipesilva Dec 3, 2018

Member

I think it was to make the dev server faster, by not running compression on dev builds.

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fine_grain_optimization branch 2 times, most recently from 9a3c5fc to 73b079c Dec 3, 2018

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fine_grain_optimization branch from 73b079c to e7b56d6 Dec 3, 2018

@alan-agius4 alan-agius4 closed this Dec 3, 2018

@alan-agius4

This comment has been minimized.

Collaborator

alan-agius4 commented Dec 3, 2018

Super seeded by #13120

@alan-agius4 alan-agius4 deleted the alan-agius4:fine_grain_optimization branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment