New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): set `optimization` and `sourceMap` in universal production config #13117

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@alan-agius4
Collaborator

alan-agius4 commented Dec 3, 2018

  • When using Universal sourceMaps should not be enabled or at least styles sourceMaps should be disabled as these will otherwise be inlined and will be set as apart of the server side rendered page.

  • While there is no benefit to optimize the scripts at server level, styles should always be minified so that the server side rendered page is smaller.

Fixes #12541 and Fixes #12940

Depends on #13116

@googlebot googlebot added the cla: yes label Dec 3, 2018

@filipesilva filipesilva requested review from filipesilva and hansl and removed request for filipesilva Dec 3, 2018

@filipesilva

This comment has been minimized.

Member

filipesilva commented Dec 3, 2018

@hansl can you have a look, since you have more context on the universal optimization problem?

fix(@schematics/angular): set `optimization` and `sourceMap` in unive…
…rsal production config

- When using Universal sourceMaps should not be enabled or at least `styles` sourceMaps should be disabled as these will otherwise be inlined and will be set as apart of the server side rendered page.

- While there is no benefit to optimize the scripts at server level, styles should always be minified so that the server side rendered page is smaller.

Fixes #12541 and Fixes #12940

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fix_prod_config_universal branch from 1271a51 to e661d0f Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment