Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@schematics/angular): extend tslint:recommended #13213

Merged
merged 1 commit into from Dec 26, 2018
Merged

feat(@schematics/angular): extend tslint:recommended #13213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
70 changes: 28 additions & 42 deletions packages/schematics/angular/workspace/files/tslint.json
View file
Open in desktop
@@ -1,32 +1,25 @@
{
"extends": "tslint:recommended",
"rulesDirectory": [
"codelyzer"
],
"rules": {
"arrow-return-shorthand": true,
"callable-types": true,
"class-name": true,
"comment-format": [
true,
"check-space"
],
"curly": true,
"adjacent-overload-signatures": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like in the current CLI and tslint this has value true, lmk if I'm wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't think it is present in the current tslint.json, so I guess it's not activated (unless I'm missing something?).

"align": false,
"array-type": false,
"arrow-parens": false,
"ban-types": false,
"deprecation": {
"severity": "warn"
},
"eofline": true,
"forin": true,
"function-constructor": false,
"import-blacklist": [
true,
"rxjs/Rx"
],
"import-spacing": true,
"indent": [
true,
"spaces"
],
"interface-over-type-literal": true,
"label-position": true,
"interface-name": false,
"jsdoc-format": false,
"max-classes-per-file": false,
"max-line-length": [
true,
140
Expand All @@ -43,8 +36,10 @@
]
}
],
"no-arg": true,
"no-bitwise": true,
"new-parens": false,
"no-angle-bracket-type-assertion": false,
"no-conditional-assignment": false,
"no-consecutive-blank-lines": false,
"no-console": [
true,
"debug",
Expand All @@ -53,28 +48,23 @@
"timeEnd",
"trace"
],
"no-construct": true,
"no-debugger": true,
"no-duplicate-super": true,
"no-empty": false,
"no-empty-interface": true,
"no-eval": true,
"no-inferrable-types": [
true,
"ignore-params"
],
"no-misused-new": true,
"no-namespace": false,
"no-non-null-assertion": true,
"no-redundant-jsdoc": true,
"no-shadowed-variable": true,
"no-reference": false,
"no-reference-import": false,
"no-string-literal": false,
"no-string-throw": true,
"no-switch-case-fall-through": true,
"no-trailing-whitespace": true,
"no-unnecessary-initializer": true,
"no-unused-expression": true,
"no-unsafe-finally": false,
"no-use-before-declare": true,
"no-var-keyword": true,
"no-var-requires": false,
"object-literal-key-quotes": false,
"object-literal-shorthand": false,
"object-literal-sort-keys": false,
"one-line": [
true,
Expand All @@ -83,20 +73,16 @@
"check-else",
"check-whitespace"
],
"prefer-const": true,
"one-variable-per-declaration": false,
"only-arrow-functions": false,
"ordered-imports": false,
"prefer-for-of": false,
"quotemark": [
true,
"single"
],
"radix": true,
"semicolon": [
true,
"always"
],
"triple-equals": [
true,
"allow-null-check"
],
"space-before-function-paren": false,
"trailing-comma": false,
"typedef-whitespace": [
true,
{
Expand All @@ -107,7 +93,7 @@
"variable-declaration": "nospace"
}
],
"unified-signatures": true,
"use-isnan": false,
"variable-name": false,
"whitespace": [
true,
Expand Down