New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport commits to 7.2.x #13397

Merged
merged 6 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jan 10, 2019

No description provided.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 10, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no label Jan 10, 2019

kyliau and others added some commits Dec 19, 2018

fix(@schematics/angular): assert no error logs in e2e
This commit adds an assertion to the e2e test to make sure there are
no error logs emitted by the browser.
test: add tests for elide imports
This also adds the option to provide addition files when using `createTypescriptContext` this is paramount for the elide imports tests as without this certain symbols won't have the full details.

Which will cause tests to be false positive and re-surface issues like #13212
fix(@ngtools/webpack): drop only unused default import when used with…
… named imports

At the moment when having a default import together with a named import example:
```
import abc, { def } from './foo';
```

And the default import becomes unused it will drop the entire node which will caused used named imports to be dropped as well.
refactor: use `getExportSpecifierLocalTargetSymbol` and `getShorthand…
…AssignmentValueSymbol` to handle symbols lookups

Use typechecker methods to handle special cases for `ExportSpecifier` and `ShorthandPropertyAssignment`

@alan-agius4 alan-agius4 force-pushed the alan-agius4:backport-commits branch from b5cddde to 248586c Jan 10, 2019

@alan-agius4 alan-agius4 changed the title Backport commits Backport commits to 7.2.x Jan 10, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:backport-commits branch from 0d63d8b to 248586c Jan 10, 2019

@alan-agius4 alan-agius4 requested review from alexeagle and hansl Jan 11, 2019

@alexeagle alexeagle added cla: yes and removed cla: no labels Jan 15, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 15, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@alexeagle alexeagle removed the request for review from hansl Jan 15, 2019

@alexeagle alexeagle merged commit 644f65d into angular:7.2.x Jan 15, 2019

12 of 13 checks passed

ci/angular: merge status 1 pending code review
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-node-8 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@alan-agius4 alan-agius4 deleted the alan-agius4:backport-commits branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment