New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional ES5 Browser Polyfill Loading #13403

Merged
merged 5 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@clydin
Copy link
Member

clydin commented Jan 10, 2019

  • no need to manually import and manage individual ES2015 polyfills required by Angular
  • ES2015 polyfills are only loaded by browsers that require them
  • Controllable via a new es5BrowserSupport option; no behavior change if option is not enabled
  • es5BrowserSupport is enabled in newly generated projects
  • allows for custom polyfill solutions by not using the new option
  • works in conjunction with conditional JIT polyfills and will load ES2015 specific JIT polyfills as needed
  • Saves ~56KB on native ES2015 browsers

@googlebot googlebot added the cla: yes label Jan 10, 2019

@clydin clydin force-pushed the clydin:polyfills branch 3 times, most recently from 53a32a0 to 9ab5eff Jan 10, 2019

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

@clydin clydin force-pushed the clydin:polyfills branch from 9ab5eff to af0f6a5 Jan 14, 2019

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

LGTM

@clydin clydin force-pushed the clydin:polyfills branch from af0f6a5 to dd4c381 Jan 14, 2019

@kyliau kyliau merged commit 668e790 into angular:master Jan 15, 2019

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size cli/new-production/test-project/3rdpartylicenses.txt increased by 2.14KB.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-node-8 Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@clydin clydin deleted the clydin:polyfills branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment