Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency from @angular-devkit/core to chokidar #13900

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@alexeagle
Copy link
Collaborator

alexeagle commented Mar 13, 2019

It is unused within our code, as webpack will do the file watching.

BREAKING CHANGE:
Users who rely on angular-devkit/core to do the file watching must add chokidar to their devDependencies.

@googlebot googlebot added the cla: yes label Mar 13, 2019

@alexeagle alexeagle force-pushed the alexeagle:chokidar_dep branch from 0fd5aa0 to 22c0113 Mar 13, 2019

feat(@angular-devkit/core): Remove dep on chokidar
It is unused within our code, as webpack will do the file watching.
This removes 1.4 MB from the download size of the package.
See https://codepen.io/alexeagle/full/zbZWRM

BREAKING CHANGE:
Users who rely on angular-devkit/core to do the file watching must add chokidar to their devDependencies.

@alexeagle alexeagle force-pushed the alexeagle:chokidar_dep branch from 22c0113 to 5a3d4a0 Mar 13, 2019

@alexeagle alexeagle requested a review from hansl Mar 13, 2019

@hansl

hansl approved these changes Mar 13, 2019

@vikerman vikerman merged commit eb5643e into angular:master Mar 13, 2019

12 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No baseline available for master / 3ac1cc30a7937784cda54f7762c5831fef6a9a59
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.