Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): resolve fonts with space in filename #13903

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Mar 13, 2019

At the moment the uri of the font instead of spaced it will be %20, hence we need to decode it first before trying to resolve it.

Fixes #9648

fix(@angular-devkit/build-angular): resolve fonts with space in filename
At the moment the uri of the font instead of spaced it will be `%20`, hence we need to decode it first before trying to resolve it.

Fixes #9648
@alan-agius4

This comment has been minimized.

Copy link
Collaborator Author

alan-agius4 commented Mar 13, 2019

Targeting master only as it's won't apply cleanly on the patch branch due to the new specs.

@alan-agius4 alan-agius4 requested a review from filipesilva Mar 13, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:font-name-space branch from 07ae3cc to 235fdfc Mar 13, 2019

fix(@angular-devkit/build-angular): don't show warning when font shor…
…thand is used

At the moment when `font` shorthand property is used a warning is emitted when using this syntax
```
font: 10px "Font Awesome";
```

This should be addressed by clean-css

Fixes #9648

@alan-agius4 alan-agius4 force-pushed the alan-agius4:font-name-space branch from 235fdfc to a4972db Mar 13, 2019

@vikerman vikerman merged commit f70b906 into angular:master Mar 13, 2019

12 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No baseline available for master / 3ac1cc30a7937784cda54f7762c5831fef6a9a59
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@alan-agius4 alan-agius4 deleted the alan-agius4:font-name-space branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.