Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Webpack Configuration Cleanup #13906

Merged
merged 2 commits into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@clydin
Copy link
Member

clydin commented Mar 13, 2019

Removes several redundant and unused methods/parameters.

clydin added some commits Mar 13, 2019

refactor(@angular-devkit/build-angular): remove redundant getNonAotTe…
…stConfig function

The `getNonAotConfig` and `getNonAotTestConfig` functions are equivalent in regards to behavior.  The `extract` optional parameter for `_createAotPlugin` is false by default.

@googlebot googlebot added the cla: yes label Mar 13, 2019

@clydin clydin requested a review from filipesilva Mar 13, 2019

@hansl

hansl approved these changes Mar 13, 2019

@clydin clydin removed the request for review from filipesilva Mar 13, 2019

@vikerman vikerman merged commit ebf90b3 into angular:master Mar 13, 2019

12 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No baseline available for master / 3ac1cc30a7937784cda54f7762c5831fef6a9a59
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@clydin clydin deleted the clydin:webpack-config-cleanup branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.