Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): allow ember, ember-cli, vendor, app and test names #13909

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
5 participants
@hansl
Copy link
Collaborator

hansl commented Mar 13, 2019

We dont care about the app name anymore.

feat(@schematics/angular): allow ember, ember-cli, vendor, app and te…
…st names

We dont care about the app name anymore.

@hansl hansl requested a review from alan-agius4 Mar 13, 2019

@hansl

This comment has been minimized.

Copy link
Collaborator Author

hansl commented Mar 13, 2019

The e2e might fail, I couldn't find if we tested that creating apps with those names failed. If that's the case I'll just change those tests to pass (to avoid regressions).

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

LGTM.

@vikerman vikerman merged commit 6acd20b into angular:master Mar 13, 2019

10 of 12 checks passed

ci/angular: merge status Status "continuous-integration/appveyor/pr" is pending
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/angular: size No baseline available for master / 3ac1cc30a7937784cda54f7762c5831fef6a9a59
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@sungdzda

This comment has been minimized.

Copy link

sungdzda commented Mar 14, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.