Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pin Angular snapshot versions #13914

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@alexeagle
Copy link
Collaborator

alexeagle commented Mar 14, 2019

Next step is to set up Renovate to send PRs against this package.json file

@googlebot googlebot added the cla: yes label Mar 14, 2019

@alan-agius4

This comment has been minimized.

Copy link
Collaborator

alan-agius4 commented Mar 14, 2019

Renovate should pick this automatically, though I am not sure if to pick it up automatically it needs to point to a branch instead of commit sha.

Let wait and see

@alexeagle alexeagle force-pushed the alexeagle:pin_ng_snapshots branch 2 times, most recently from f7ef30d to 53ca8c2 Mar 14, 2019

test: pin Angular snapshot versions
Next step is to set up Renovate to send PRs against this package.json file

@alexeagle alexeagle force-pushed the alexeagle:pin_ng_snapshots branch from 53ca8c2 to bfa0a52 Mar 14, 2019

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

Looks good to me, though I will do a PR to enable renovate on the new package.json as I noticed it's not in the paths specified.

@alexeagle alexeagle merged commit b344ba4 into angular:master Mar 14, 2019

14 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ivy-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.