Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golden files for core and architect #14149

Merged
merged 3 commits into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Apr 12, 2019

Add analytics to core golden files
Add architect api to golden files

Remove _golden-api.ts from architect as we are no longer exporting namespaces

@filipesilva
Copy link
Member

filipesilva left a comment

The changes lgtm, but shouldn't these changes have been needed before? Why didn't the API guardian tests fail on the PRs that introduced it?

@alan-agius4

This comment has been minimized.

Copy link
Collaborator Author

alan-agius4 commented Apr 12, 2019

Because the new APIs have never been added to the golden_api.d.ts.

Since we are using export * as foo from ./foo we need to keep golden_api in sync, since namespaces are not supported.

Also, good to remember that API guardian uses classic module resolution, and will completely ignore modules which cannot be resolved.

@alan-agius4 alan-agius4 force-pushed the alan-agius4:public_api_golden branch from e82aeb8 to 332dd3d Apr 13, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:public_api_golden branch from 332dd3d to 32d4cee Apr 13, 2019

@alexeagle alexeagle merged commit da628bd into angular:master Apr 15, 2019

14 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ivy Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.