Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): adjust WebpackConfigurationT… #14159

Closed

Conversation

Projects
None yet
3 participants
@manfredsteyer
Copy link
Contributor

manfredsteyer commented Apr 14, 2019

…ransformer for parity with other builders

Like the browser builder and the dev-server builder, the karma builder
allows to pass a hook for manipulating the webpack conf. However, this
hook looks different than in the before mentioned builders. For the sake
of parity, this PR changes this.

@googlebot googlebot added the cla: yes label Apr 14, 2019

@manfredsteyer manfredsteyer force-pushed the manfredsteyer:karma-builder-hook branch from 80c47e8 to 5e5cc76 Apr 14, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 14, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 14, 2019

@manfredsteyer manfredsteyer force-pushed the manfredsteyer:karma-builder-hook branch from 5e5cc76 to bd622d8 Apr 14, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 14, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 14, 2019

refactor(@angular-devkit/build-angular): adjust WebpackConfigurationT…
…ransformer for parity with other builders

Like the browser builder and the dev-server builder, the karma builder
allows to pass a hook for manipulating the webpack conf. However, this
hook looks different than in the before mentioned builders. For the sake
of parity, this PR changes this.

@manfredsteyer manfredsteyer force-pushed the manfredsteyer:karma-builder-hook branch from bd622d8 to b0dd28d Apr 14, 2019

@clydin

This comment has been minimized.

Copy link
Member

clydin commented Apr 14, 2019

Superseded by #14160

@clydin clydin closed this Apr 14, 2019

@manfredsteyer

This comment has been minimized.

Copy link
Contributor Author

manfredsteyer commented Apr 15, 2019

Cool. #14160 is exactly what I need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.