Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder Transforms Standardization #14160

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Projects
None yet
4 participants
@clydin
Copy link
Member

clydin commented Apr 14, 2019

This adds Webpack configuration transform support to the server builder and also standardizes the transform usage across the currently support builders.

@alan-agius4
Copy link
Collaborator

alan-agius4 left a comment

LGTM,

Though I find it a bit misleading the the methods are called generateBrowserWebpackConfigFromContext , generateBrowserWebpackConfigFromWorkspace etc...

But this is a small NIT that can be changes in a seperate PR if deemed needed.

@clydin clydin force-pushed the clydin:builder-transforms branch from 1038168 to 72b5a14 Apr 15, 2019

@alexeagle alexeagle merged commit 2b23454 into angular:master Apr 15, 2019

14 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ivy Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@clydin clydin deleted the clydin:builder-transforms branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.