Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Bazel from npm #14170

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@alexeagle
Copy link
Collaborator

alexeagle commented Apr 15, 2019

Also hook up bazel format/lint

@alexeagle alexeagle requested a review from filipesilva Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@alexeagle alexeagle force-pushed the alexeagle:update_bazel branch from 33645eb to d7ffb1a Apr 15, 2019

@@ -20,6 +20,10 @@
],
"scripts": {
"admin": "node ./bin/devkit-admin",

This comment has been minimized.

Copy link
@alan-agius4

alan-agius4 Apr 15, 2019

Collaborator

Nit: would be nice to have "bazel": "bazel",

This comment has been minimized.

Copy link
@clydin

clydin Apr 15, 2019

Member

npx bazel?

This comment has been minimized.

Copy link
@filipesilva

filipesilva Apr 15, 2019

Member

Having the script proper is better I feel. It makes it pretty obvious that it's the right way of using bazel, whether via yarn or npm, and it's more ergonomic for scripts too. I don't know if all the docker images we use have npx either, but I guess they would.

This comment has been minimized.

Copy link
@clydin

clydin Apr 15, 2019

Member

It comes with npm. If you’re only using yarn you should be able to just do ‘yarn bazel’

This comment has been minimized.

Copy link
@alexeagle

alexeagle Apr 16, 2019

Author Collaborator

yeah you can yarn bazel if you want to pick your targets.

@alexeagle alexeagle force-pushed the alexeagle:update_bazel branch 3 times, most recently from 1a3d1e9 to 2a7dbd3 Apr 15, 2019

alexeagle added some commits Apr 15, 2019

build: use Bazel from npm
Also hook up bazel format/lint
build: skip license check for @bazel packages
need to fix them upstream

@alexeagle alexeagle force-pushed the alexeagle:update_bazel branch 3 times, most recently from 19df2c2 to 84a57fe Apr 15, 2019

@filipesilva
Copy link
Member

filipesilva left a comment

Mostly LGTM, a few requests.

Show resolved Hide resolved .circleci/config.yml
@@ -73,6 +73,14 @@ const ignoredPackages = [
'true-case-path@1.0.2', // Apache-2.0 but broken license in package.json
'uws@9.14.0', // zlib license

// * Need to publish these with LICENSE files
// see https://github.com/bazelbuild/rules_nodejs/pull/696

This comment has been minimized.

Copy link
@filipesilva

filipesilva Apr 16, 2019

Member

bazelbuild/rules_nodejs#696 is now merged, can we get a release that removes this TODO?

This comment has been minimized.

Copy link
@alexeagle

alexeagle Apr 16, 2019

Author Collaborator

well, the npm version numbers for the bazel packages are identical to the upstream version numbers. If I publish @bazel/bazel@0.24.2 it will be confusing since the latest is https://github.com/bazelbuild/bazel/releases/tag/0.24.1

var_1: &docker_image circleci/node:10.12
var_2: &cache_key angular_devkit-0.10.0-{{ checksum "yarn.lock" }}
var_1: &default_docker_image circleci/node:10.12
var_2: &browsers_docker_image circleci/node:10.12-browsers

This comment has been minimized.

Copy link
@filipesilva

filipesilva Apr 16, 2019

Member

Is this needed? We use puppeteer for our e2e tests so I didn't expect it to be necessary.

This comment has been minimized.

Copy link
@alexeagle

alexeagle Apr 16, 2019

Author Collaborator

sadly headless chrome still requires dynamic linked dependency on libx11 which is pretty lame. We should raise with the Chrome team.

@alexeagle alexeagle force-pushed the alexeagle:update_bazel branch from 84a57fe to ee1a093 Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.