Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Angular Schematic updates to new workspace rules #14173

Merged
merged 12 commits into from Apr 16, 2019

Conversation

Projects
None yet
4 participants
@clydin
Copy link
Member

clydin commented Apr 16, 2019

This fixes several bugs and updates the remainder of the Angular schematics. Each schematic update is in a separate commit. Tests needed to be updated to use the async version of the test runner but are otherwise unmodified.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 16, 2019

☹️ Sorry, but only Googlers may change the label cla: yes.

@clydin clydin requested a review from filipesilva Apr 16, 2019

@clydin clydin force-pushed the clydin:workspace-schematics branch from 9e081ad to 563eb09 Apr 16, 2019

@filipesilva
Copy link
Member

filipesilva left a comment

LGTM up to the last commit I saw.

@clydin clydin force-pushed the clydin:workspace-schematics branch from 563eb09 to 9b00cca Apr 16, 2019

@clydin clydin force-pushed the clydin:workspace-schematics branch 2 times, most recently from 5818691 to 15e8891 Apr 16, 2019

@clydin clydin force-pushed the clydin:workspace-schematics branch from 15e8891 to 1cde0fb Apr 16, 2019

@alexeagle alexeagle merged commit 52a014d into angular:master Apr 16, 2019

12 of 14 checks passed

ci/angular: merge status Status "continuous-integration/appveyor/pr" is pending
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ivy Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

@clydin clydin deleted the clydin:workspace-schematics branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.