fix(@schematics/angular): align differential loading migration to br… #14226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested changes
Apr 22, 2019
There was a problem hiding this comment.
Hi @emilio-martinez ,
Thanks for this, can you please fix the failing tests and also change the commit to a fix?
…wserslist template Modifies differential loading migration script to align with the changes in 4d7581d to support Googlebot in browserslist by default.
emilio-martinez
force-pushed
the
fix/diff-loading-migration-content
branch
from
9a0c254
to
abbc4a5
Compare
emilio-martinez
changed the title
|
@alan-agius4 Sure thing on both counts. Ready for your review. |
alan-agius4
requested changes
Apr 23, 2019
alan-agius4
approved these changes
Apr 23, 2019
alan-agius4
added
the
target: patch
alexeagle
reviewed
Apr 23, 2019
| not dead | ||
| not IE 9-11 # For IE 9-11 support, remove 'not'. | ||
| not Chrome 41 # For Googlebot support, remove 'not'.`; | ||
| not IE 9-11 # For IE 9-11 support, remove 'not'.`; |
There was a problem hiding this comment.
some strange stray characters here. I'll merge anyway to unblock release, could fix in a follow-up?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…owserslist template
Modifies differential loading migration script to align with the changes in 4d7581d to support Googlebot in browserslist by default.