Skip to content

fix(@schematics/angular): improve pipe signature#14785

Merged
mgechev merged 1 commit intoangular:masterfrom
LakhyariMs:fix/pipe
Jun 20, 2019
Merged

fix(@schematics/angular): improve pipe signature#14785
mgechev merged 1 commit intoangular:masterfrom
LakhyariMs:fix/pipe

Conversation

@LakhyariMs
Copy link
Contributor

Currently , the CLI generates :

transform(value: any , args?: any)

With this commit , it generate :

transform(value: any, ...args?: any[])

Which conforms to the official doc

Fixes #12602

Currently , the CLI generates :

```typescript

transform(value: any , args?: any)

```

With this commit , it generate :

```typescript

transform(value: any, ...args?: any[])

```

Which conforms to the official doc

Fixes angular#12602
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@LakhyariMs
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@cexbrayat
Copy link
Member

Note to the team: this is a first time contributor, contributing to the CLI during the HackCommitPush conference, which aims to help developers to contribute to open source projects :)

The CI flake looks unrelated (failure in analytics_spec.ts)

@clydin clydin added the target: major This PR is targeted for the next major release label Jun 15, 2019
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jun 19, 2019
@mgechev mgechev merged commit 5339611 into angular:master Jun 20, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipe generated transform method has wrong parameters

6 participants