Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): improve pipe signature #14785

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@LakhyariMs
Copy link
Contributor

commented Jun 15, 2019

Currently , the CLI generates :

transform(value: any , args?: any)

With this commit , it generate :

transform(value: any, ...args?: any[])

Which conforms to the official doc

Fixes #12602

fix(@schematics/angular): improve pipe signature
Currently , the CLI generates :

```typescript

transform(value: any , args?: any)

```

With this commit , it generate :

```typescript

transform(value: any, ...args?: any[])

```

Which conforms to the official doc

Fixes #12602
@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 15, 2019

@LakhyariMs

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Jun 15, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 15, 2019

@cexbrayat

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Note to the team: this is a first time contributor, contributing to the CLI during the HackCommitPush conference, which aims to help developers to contribute to open source projects :)

The CI flake looks unrelated (failure in analytics_spec.ts)

@LakhyariMs LakhyariMs force-pushed the LakhyariMs:fix/pipe branch from a0deb9a to 389ea92 Jun 15, 2019

@clydin

clydin approved these changes Jun 19, 2019

@mgechev mgechev merged commit 5339611 into angular:master Jun 20, 2019

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ivy Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.