Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): feature PWA in CLI app #15495

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@christianliebel
Copy link
Contributor

commented Aug 31, 2019

Let’s increase the discoverability of Angular’s PWA support by featuring the ng add @angular/pwa command in the new CLI app.

image

feat(@schematics/angular): feature PWA in CLI app
Feature PWA support via `@angular/pwa` directly in the new CLI app.
@alan-agius4

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

@mgechev / @sjtrimble thoughts?

@sjtrimble
Copy link
Contributor

left a comment

I like this!

@alan-agius4

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

@christianliebel, can you please rebase to make this green?

@christianliebel

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@alan-agius4 It should already be up to date with master.

@vikerman vikerman merged commit 8527206 into angular:master Sep 3, 2019

18 checks passed

ci/angular: merge status All checks passed!
ci/angular: size cli/new-production/test-project/main-es2015.js increased by 300 bytes.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

@christianliebel christianliebel deleted the christianliebel:feature/feature-pwa branch Sep 4, 2019

@mgechev

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

❤️❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.