Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update FW size expectations #16099

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@filipesilva
Copy link
Member

filipesilva commented Nov 7, 2019

We verified this size change happens just from increasing FW version from 9.0.0-rc.0 to 9.0.0-rc.1

CLI master with FW rc.1:

141032 Nov  6 20:08 main-es2015.ed01ec5f480fa886325f.js
163321 Nov  6 20:08 main-es5.ed01ec5f480fa886325f.js
 36808 Nov  6 20:08 polyfills-es2015.b6fe2b19564e29c5d554.js
127927 Nov  6 20:08 polyfills-es5.9cbeb6b4a192c8c548fe.js
  1485 Nov  6 20:08 runtime-es2015.52756d3ab8e6582f0541.js
  1485 Nov  6 20:08 runtime-es5.52756d3ab8e6582f0541.js

CLI master with FW rc.0:

139902 Nov  6 20:05 main-es2015.cd909d61c6a4766689e9.js
162180 Nov  6 20:05 main-es5.cd909d61c6a4766689e9.js
 36808 Nov  6 20:05 polyfills-es2015.b6fe2b19564e29c5d554.js
127927 Nov  6 20:05 polyfills-es5.9cbeb6b4a192c8c548fe.js
  1485 Nov  6 20:05 runtime-es2015.52756d3ab8e6582f0541.js
  1485 Nov  6 20:05 runtime-es5.52756d3ab8e6582f0541.js

Likely related to these PRs:

We verified this size change happens just from increasing FW version from 9.0.0-rc.0 to 9.0.0-rc.1

CLI master with FW rc.1:
```
141032 Nov  6 20:08 main-es2015.ed01ec5f480fa886325f.js
163321 Nov  6 20:08 main-es5.ed01ec5f480fa886325f.js
 36808 Nov  6 20:08 polyfills-es2015.b6fe2b19564e29c5d554.js
127927 Nov  6 20:08 polyfills-es5.9cbeb6b4a192c8c548fe.js
  1485 Nov  6 20:08 runtime-es2015.52756d3ab8e6582f0541.js
  1485 Nov  6 20:08 runtime-es5.52756d3ab8e6582f0541.js
```
CLI master with FW rc.0:
```
139902 Nov  6 20:05 main-es2015.cd909d61c6a4766689e9.js
162180 Nov  6 20:05 main-es5.cd909d61c6a4766689e9.js
 36808 Nov  6 20:05 polyfills-es2015.b6fe2b19564e29c5d554.js
127927 Nov  6 20:05 polyfills-es5.9cbeb6b4a192c8c548fe.js
  1485 Nov  6 20:05 runtime-es2015.52756d3ab8e6582f0541.js
  1485 Nov  6 20:05 runtime-es5.52756d3ab8e6582f0541.js
```

Likely related to these PRs:
- angular/angular#33602
- angular/angular#33540
- angular/angular#31270
@clydin
clydin approved these changes Nov 7, 2019
@vikerman vikerman merged commit 3558220 into angular:master Nov 7, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size cli/new-production/test-project/main-es5.js increased by 1.38KB.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.