Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): use spawned process error when it's available #16102

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Nov 7, 2019

In some cases when an error occurs in the spawned process the error property will be populated instead of stderr or stdout.

See: https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options

In some cases when an error occurs in the spawned process the `error` property will be populated instead of `stderr` or `stdout`.

See: https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options
@vikerman vikerman merged commit f35b80e into angular:master Nov 7, 2019
14 of 17 checks passed
14 of 17 checks passed
ci/angular: size Unable to calculate sizes. Failure: "ci/circleci: e2e-cli"
ci/angular: merge status Status "ci/angular: size" is failing, status "ci/circleci: e2e-cli" is failing
ci/circleci: e2e-cli Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.