Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): prevent double sourcemap processing #16126

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@clydin
Copy link
Member

clydin commented Nov 9, 2019

Fixes the CI failure for #16065 and provides a noticeable memory improvement. The failing test from the aforementioned PR went from 2GB to process the main bundle to just over 550MB.

@clydin clydin requested a review from alan-agius4 Nov 9, 2019
@googlebot googlebot added the cla: yes label Nov 9, 2019
@clydin clydin force-pushed the clydin:fix-double-sourcemaps branch from 7e69815 to d4a0e19 Nov 9, 2019
@mgechev mgechev merged commit 6602d90 into angular:master Nov 11, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@clydin clydin deleted the clydin:fix-double-sourcemaps branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.