Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): pass webpack factor to runWebpack… #16317

Merged
merged 2 commits into from Dec 2, 2019

Conversation

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Nov 29, 2019

…DevServer

@alan-agius4 alan-agius4 requested a review from clydin Nov 29, 2019
@googlebot googlebot added the cla: yes label Nov 29, 2019
@alan-agius4 alan-agius4 force-pushed the alan-agius4:pass-webpack-factory-dev branch 3 times, most recently from 8656bb8 to 7bcb92a Nov 29, 2019
@clydin
clydin approved these changes Nov 29, 2019
…pt a webpackDevServerFactory
@alan-agius4 alan-agius4 force-pushed the alan-agius4:pass-webpack-factory-dev branch from 7bcb92a to 7d17c84 Nov 29, 2019
@mgechev mgechev merged commit d155c7c into angular:master Dec 2, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@alan-agius4 alan-agius4 deleted the alan-agius4:pass-webpack-factory-dev branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.