Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: strip leading slash to prevent confusion #16334

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Dec 2, 2019

No description provided.

@alan-agius4 alan-agius4 force-pushed the alan-agius4:leading-slash-paths branch from 4906cb8 to dc770e9 Dec 2, 2019
Copy link
Member

filipesilva left a comment

I'm ok with this, but @clydin would be a better reviewer because I'm not too sure if this causes messages to be inconsistent.

@filipesilva filipesilva requested a review from clydin Dec 2, 2019
@clydin
clydin approved these changes Dec 2, 2019
@mgechev mgechev merged commit 35ca390 into angular:master Dec 2, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@alan-agius4 alan-agius4 deleted the alan-agius4:leading-slash-paths branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.