Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip! replace parser #16646

Draft
wants to merge 1 commit into
base: master
from
Draft

wip! replace parser #16646

wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jan 11, 2020

No description provided.

@googlebot googlebot added the cla: yes label Jan 11, 2020
@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Jan 11, 2020

"yargs" FTW 🏋
The title of the PR was a bit misleading initially :-) I thought you were replacing some code parser 🙀

@alan-agius4 alan-agius4 force-pushed the alan-agius4:parser branch from 31d1872 to a8ffbf2 Jan 11, 2020
@alan-agius4

This comment has been minimized.

Copy link
Collaborator Author

alan-agius4 commented Jan 11, 2020

Hahaha... someone is watching the CLI repo.

Actually, I replaced it with the parser that yargs uses which is yargs-parser. As the parser alone is enough as we don't need to full yargs functionality.

Ps: this is still a POC, hopefully we can land it 😄

@alan-agius4 alan-agius4 force-pushed the alan-agius4:parser branch 5 times, most recently from 850b258 to 3a673f1 Jan 11, 2020
@alan-agius4 alan-agius4 force-pushed the alan-agius4:parser branch from 3a673f1 to aa516d5 Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.