Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): default to NodeJS value for pres… #16648

Open
wants to merge 1 commit into
base: master
from

Conversation

@Toxicable
Copy link
Contributor

Toxicable commented Jan 11, 2020

…erveSymlinks

Under bazel preserveSymlinks would have to be set in two different places, this makes it so it only has to be set once by using the value from NodeJS if it's set.

@googlebot googlebot added the cla: yes label Jan 11, 2020
@Toxicable

This comment has been minimized.

Copy link
Contributor Author

Toxicable commented Jan 11, 2020

Not sure if this is the right place to put this config, let me know if there's a better place to set it.

@clydin

This comment has been minimized.

Copy link
Member

clydin commented Jan 17, 2020

I’m ok with using it as a default. However, it would be a breaking change since the default would be different for some people. This could manifest in either broken builds or builds containing different dependencies than anticipated or expected. As a feature, this would probably fall into the v10 timeframe.

@Toxicable Toxicable force-pushed the Toxicable:preserve-symlink-nodejs branch 2 times, most recently from e3699cb to f5d55dd Jan 17, 2020
@Toxicable

This comment has been minimized.

Copy link
Contributor Author

Toxicable commented Jan 17, 2020

@clydin Sounds good to me, how would we make sure to come back and check this when there's a v10 branch?

@alan-agius4

This comment has been minimized.

Copy link
Collaborator

alan-agius4 commented Jan 17, 2020

@Toxicable, I can create a v10 milestone and assign this Pr to it.

@alan-agius4 alan-agius4 added this to the V10-candidates milestone Jan 17, 2020
@Toxicable Toxicable force-pushed the Toxicable:preserve-symlink-nodejs branch 2 times, most recently from 826bdc6 to 6105bf4 Jan 17, 2020
@alan-agius4 alan-agius4 changed the title feat(@angualr-devkit/build-angular): default to NodeJS value for pres… feat(@angular-devkit/build-angular): default to NodeJS value for pres… Jan 17, 2020
@Toxicable Toxicable force-pushed the Toxicable:preserve-symlink-nodejs branch from 6105bf4 to 3282882 Jan 17, 2020
@Toxicable Toxicable force-pushed the Toxicable:preserve-symlink-nodejs branch from 3282882 to 611a57c Jan 17, 2020
Copy link
Collaborator

alan-agius4 left a comment

Thanks Fabian! LGTM.

@alan-agius4 alan-agius4 self-assigned this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.