Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove pnpm engine value due to lack of yarn support #16652

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@clydin
Copy link
Member

clydin commented Jan 13, 2020

Yarn displays a warning due to an unknown engine value of pnpm. Until this is corrected upstream, the value can be temporarily removed to eliminate the multiple, but otherwise harmless, warnings shown to users upon package install.

Yarn Issue: yarnpkg/yarn#7560
Yarn PR: yarnpkg/yarn#7566

Yarn displays a warning due to an unknown engine value of `pnpm`.  Until this is corrected upstream, the value can be temporarily removed to eliminate the multiple, but otherwise harmless, warnings shown to users upon package install.
@dgp1130

This comment has been minimized.

Copy link
Collaborator

dgp1130 commented Jan 15, 2020

Is this ready to merge? Should it have the PR action: merge label?

@mgechev mgechev merged commit 59cf170 into angular:master Jan 15, 2020
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
@clydin clydin deleted the clydin:package-engine-pnpm branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.