From 748ba55d2d43518e60cb4bd186cb48a70fb3ac4b Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Wed, 7 Oct 2020 12:42:02 -0400 Subject: [PATCH] fix(@angular-devkit/core): remove deprecated isObservable function BREAKING CHANGE: Deprecated `isObservable` function removed. As an alternative, use `isObservable` from the `rxjs` package. NOTE: This change does not affect application development. --- .../angular_devkit/core/src/_golden-api.d.ts | 2 -- packages/angular_devkit/core/src/utils/lang.ts | 18 ------------------ 2 files changed, 20 deletions(-) diff --git a/etc/api/angular_devkit/core/src/_golden-api.d.ts b/etc/api/angular_devkit/core/src/_golden-api.d.ts index b5c94fcc4210..a3077acba2dd 100644 --- a/etc/api/angular_devkit/core/src/_golden-api.d.ts +++ b/etc/api/angular_devkit/core/src/_golden-api.d.ts @@ -308,8 +308,6 @@ export declare function isJsonArray(value: JsonValue): value is JsonArray; export declare function isJsonObject(value: JsonValue): value is JsonObject; -export declare function isObservable(obj: any | Observable): obj is Observable; - export declare function isPromise(obj: any): obj is Promise; export declare function join(p1: Path, ...others: string[]): Path; diff --git a/packages/angular_devkit/core/src/utils/lang.ts b/packages/angular_devkit/core/src/utils/lang.ts index cca193771732..032010566a7a 100644 --- a/packages/angular_devkit/core/src/utils/lang.ts +++ b/packages/angular_devkit/core/src/utils/lang.ts @@ -6,7 +6,6 @@ * found in the LICENSE file at https://angular.io/license */ // Borrowed from @angular/core -import { Observable } from 'rxjs'; /** * Determine if the argument is shaped like a Promise @@ -17,20 +16,3 @@ export function isPromise(obj: any): obj is Promise { // It's up to the caller to ensure that obj.then conforms to the spec return !!obj && typeof obj.then === 'function'; } - -/** - * Determine if the argument is an Observable - * @deprecated as of 8.0; use rxjs' built-in version - */ -// tslint:disable-next-line:no-any -export function isObservable(obj: any | Observable): obj is Observable { - if (!obj || typeof obj !== 'object') { - return false; - } - - if (Symbol.observable && Symbol.observable in obj) { - return true; - } - - return typeof obj.subscribe === 'function'; -}