From ccf909ee81c2b3d5e80dc58a32632e398cf10962 Mon Sep 17 00:00:00 2001 From: Felix Hamann Date: Tue, 25 Oct 2022 10:22:37 +0200 Subject: [PATCH] feat(@schematics/angular): add sideEffects:false to library package.json --- .../angular/library/files/package.json.template | 5 +++-- packages/schematics/angular/library/index_spec.ts | 8 ++++++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/schematics/angular/library/files/package.json.template b/packages/schematics/angular/library/files/package.json.template index dde7d4962122..1d50c8cbcc34 100644 --- a/packages/schematics/angular/library/files/package.json.template +++ b/packages/schematics/angular/library/files/package.json.template @@ -7,5 +7,6 @@ }, "dependencies": { "tslib": "^<%= tsLibLatestVersion %>" - } -} \ No newline at end of file + }, + "sideEffects": false +} diff --git a/packages/schematics/angular/library/index_spec.ts b/packages/schematics/angular/library/index_spec.ts index 8e5cc7d1e398..7a009b6ac236 100644 --- a/packages/schematics/angular/library/index_spec.ts +++ b/packages/schematics/angular/library/index_spec.ts @@ -126,6 +126,14 @@ describe('Library Schematic', () => { expect(fileContent.peerDependencies['@angular/core']).toBe(`^${angularVersion}`); }); + it('should add sideEffects: false flag to package.json named "foo"', async () => { + const tree = await schematicRunner + .runSchematicAsync('library', defaultOptions, workspaceTree) + .toPromise(); + const fileContent = getFileContent(tree, '/projects/foo/package.json'); + expect(fileContent).toMatch(/"sideEffects": false/); + }); + it('should create a README.md named "foo"', async () => { const tree = await schematicRunner .runSchematicAsync('library', defaultOptions, workspaceTree)