From 33ca4f3c9601c1a7c74c7de25c0fda77ed052986 Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Mon, 10 Apr 2023 17:23:51 -0400 Subject: [PATCH] test(@angular-devkit/build-angular): enable additional styles tests for esbuild builder Now that output stat logging for the esbuild-based browser application builder has been implemented, the previously disabled styles option tests can be enabled. --- .../browser-esbuild/tests/options/styles_spec.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts index efccdb87dbce..02b26e83f164 100644 --- a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts +++ b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/tests/options/styles_spec.ts @@ -129,8 +129,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => { harness.expectFile('dist/styles.css').toNotExist(); }); - // TODO: Re-enable once output logging is implemented for esbuild builder - xit('shows the output style as a chunk entry in the logging output', async () => { + it('shows the output style as a chunk entry in the logging output', async () => { await harness.writeFile('src/test-style-a.css', '.test-a {color: red}'); harness.useTarget('build', { @@ -401,8 +400,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => { .content.not.toContain(''); }); - // TODO: Re-enable once output logging is implemented for esbuild builder - xit('shows the output style as a chunk entry in the logging output', async () => { + it('shows the output style as a chunk entry in the logging output', async () => { await harness.writeFile('src/test-style-a.css', '.test-a {color: red}'); harness.useTarget('build', { @@ -419,8 +417,7 @@ describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => { ); }); - // TODO: Re-enable once output logging is implemented for esbuild builder - xit('shows the output style as a chunk entry with bundleName in the logging output', async () => { + it('shows the output style as a chunk entry with bundleName in the logging output', async () => { await harness.writeFile('src/test-style-a.css', '.test-a {color: red}'); harness.useTarget('build', {