From 65483c5e17315aa075eef4b13d7218aab3b6830d Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Thu, 14 Mar 2024 14:32:33 +0000 Subject: [PATCH 1/2] refactor(@schematics/angular): remove internal `linkCli` ng-new option `yarn ng-dev misc build-and-link ` should be used instead. --- packages/schematics/angular/ng-new/index.ts | 7 ------- packages/schematics/angular/ng-new/schema.json | 6 ------ 2 files changed, 13 deletions(-) diff --git a/packages/schematics/angular/ng-new/index.ts b/packages/schematics/angular/ng-new/index.ts index 116162821f81..964c3667d58c 100644 --- a/packages/schematics/angular/ng-new/index.ts +++ b/packages/schematics/angular/ng-new/index.ts @@ -20,7 +20,6 @@ import { } from '@angular-devkit/schematics'; import { NodePackageInstallTask, - NodePackageLinkTask, RepositoryInitializerTask, } from '@angular-devkit/schematics/tasks'; import { Schema as ApplicationOptions } from '../application/schema'; @@ -77,12 +76,6 @@ export default function (options: NgNewOptions): Rule { packageManager: options.packageManager, }), ); - if (options.linkCli) { - packageTask = context.addTask( - new NodePackageLinkTask('@angular/cli', options.directory), - [packageTask], - ); - } } if (!options.skipGit) { const commit = diff --git a/packages/schematics/angular/ng-new/schema.json b/packages/schematics/angular/ng-new/schema.json index 0c776b709542..1c31bf093569 100644 --- a/packages/schematics/angular/ng-new/schema.json +++ b/packages/schematics/angular/ng-new/schema.json @@ -24,12 +24,6 @@ "type": "boolean", "default": false }, - "linkCli": { - "description": "Link the CLI to the global version (internal development only).", - "type": "boolean", - "default": false, - "visible": false - }, "skipGit": { "description": "Do not initialize a git repository.", "type": "boolean", From 334555f08fa19e5b0d3198b2c9510ec97315ef23 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Thu, 14 Mar 2024 14:46:03 +0000 Subject: [PATCH 2/2] refactor(@angular-devkit/schematics): deprecate `NodePackageLinkTask` DEPRECATED: `NodePackageLinkTask` in `@angular-devkit/schematics`. A custom task should be created instead. --- .../public-api/angular_devkit/schematics/tasks/index.md | 2 +- .../schematics/tasks/package-manager/link-task.ts | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/goldens/public-api/angular_devkit/schematics/tasks/index.md b/goldens/public-api/angular_devkit/schematics/tasks/index.md index a6e0783f1ce2..c4f46fbff162 100644 --- a/goldens/public-api/angular_devkit/schematics/tasks/index.md +++ b/goldens/public-api/angular_devkit/schematics/tasks/index.md @@ -27,7 +27,7 @@ export class NodePackageInstallTask implements TaskConfigurationGenerator { constructor(packageName?: string | undefined, workingDirectory?: string | undefined); // (undocumented) diff --git a/packages/angular_devkit/schematics/tasks/package-manager/link-task.ts b/packages/angular_devkit/schematics/tasks/package-manager/link-task.ts index 114aa8658813..b13ea6460e1c 100644 --- a/packages/angular_devkit/schematics/tasks/package-manager/link-task.ts +++ b/packages/angular_devkit/schematics/tasks/package-manager/link-task.ts @@ -9,10 +9,16 @@ import { TaskConfiguration, TaskConfigurationGenerator } from '../../src'; import { NodePackageName, NodePackageTaskOptions } from './options'; +/** + * @deprecated since version 18. Create a custom task if required. + */ export class NodePackageLinkTask implements TaskConfigurationGenerator { quiet = true; - constructor(public packageName?: string, public workingDirectory?: string) {} + constructor( + public packageName?: string, + public workingDirectory?: string, + ) {} toConfiguration(): TaskConfiguration { return {