Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/build): Auto-CSP support as a part of angular.json schema #28663

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

aaronshim
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

There are no angular.json configurations to add the auto-csp to the index.html transformation.

Issue Number: N/A

What is the new behavior?

There are angular.json configurations to add the auto-csp to the index.html transformation.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR also contains content from #28639. Please ignore the files changed in that previous PR and instead on

  • packages/angular/build/src/utils/index-file/index-html-generator.ts
  • packages/angular/build/src/tools/esbuild/index-html-generator.ts
  • packages/angular/build/src/builders/application/schema.json
  • packages/angular/build/src/builders/application/options.ts

@dgp1130 dgp1130 requested review from dgp1130 and clydin October 18, 2024 01:28
@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 18, 2024
@dgp1130 dgp1130 added this to the v19 Candidates milestone Oct 18, 2024
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major concerns on my end here, just want to make sure we agree on the option name and that it's wired up correctly for SSR users.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 22, 2024
Following up on the logic provided in angular#28639, we want to offer an opt-in
option in angular.json to enable the auto-CSP transformation.

For now, builds for `ng serve` will have Auto-CSP disabled.
@dgp1130 dgp1130 removed the request for review from clydin October 22, 2024 22:46
@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 22, 2024
@dgp1130 dgp1130 merged commit efb4341 into angular:main Oct 22, 2024
31 checks passed
@aaronshim aaronshim mentioned this pull request Oct 23, 2024
13 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants