fix(@schematics/angular): add additional checks for application builder usage #29687
Conversation
clydin
force-pushed
the
schematics/app-support-improvements
branch
3 times, most recently
from
9820e26 to
94b86b1
Compare
clydin
added
the
action: review
| ExtractI18n = '@angular-devkit/build-angular:extract-i18n', | ||
| BuildExtractI18n = '@angular/build:extract-i18n', | ||
| Protractor = '@angular-devkit/build-angular:private-protractor', | ||
| BuildApplication = '@angular/build:application', |
There was a problem hiding this comment.
Consider: I see that X and BuildX is an existing convention, but I wonder if it would be worth renaming the existing ones to DevkitX, XDevkit, or something similar to be more clear about the distinction between them.
Alternatively we could potentially drop the BuildX prefix with that being the "default" option we want to use, with DevkitX being the legacy versions.
If we do make this change, it's probably worth a separate PR, but something to think about.
There was a problem hiding this comment.
While these are "internal", they have been and probably still are used by third-party custom schematics. This makes more comprehensive changes problematic. I do like the Devkit variation though.
…er usage The Angular schematics have been updated to perform additional checks for both the `@angular-devkit/build-angular:application` and `@angular/build:application` builders. This ensures that the schematics generate the appropriate output for each of these build systems in addition to the Webpack-based `browser` builder.
clydin
force-pushed
the
schematics/app-support-improvements
branch
from
94b86b1 to
061b657
Compare
clydin
added
action: merge
|
The changes were merged into the following branches: main, 19.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
The Angular schematics have been updated to perform additional checks for both the
@angular-devkit/build-angular:applicationand@angular/build:applicationbuilders. This ensures that the schematics generate the appropriate output for each of these build systems in addition to the Webpack-basedbrowserbuilder.