From d1f1c11db458183ea44822caa7d30731d2b9f68e Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Tue, 1 Apr 2025 09:22:45 +0000 Subject: [PATCH] refactor: remove dependency on `symbol-observable` --- eslint.config.mjs | 8 -------- package.json | 1 - packages/angular/cli/BUILD.bazel | 1 - packages/angular/cli/lib/init.ts | 2 -- packages/angular/cli/package.json | 1 - .../angular_devkit/architect_cli/package.json | 1 - .../angular_devkit/schematics_cli/BUILD.bazel | 1 - .../schematics_cli/bin/schematics.ts | 2 -- .../angular_devkit/schematics_cli/package.json | 1 - pnpm-lock.yaml | 18 ------------------ 10 files changed, 36 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index dd6ed8fbae63..eeb7f6c60cd2 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -121,14 +121,6 @@ export default [ 'import/newline-after-import': 'error', 'import/no-absolute-path': 'error', 'import/no-duplicates': 'error', - - 'import/no-unassigned-import': [ - 'error', - { - allow: ['symbol-observable'], - }, - ], - 'import/order': [ 'error', { diff --git a/package.json b/package.json index 4591f5ad3eb3..67afdbd08d50 100644 --- a/package.json +++ b/package.json @@ -135,7 +135,6 @@ "semver": "7.7.1", "shelljs": "^0.9.0", "source-map-support": "0.5.21", - "symbol-observable": "4.0.0", "tar": "^7.0.0", "ts-node": "^10.9.1", "tslib": "2.8.1", diff --git a/packages/angular/cli/BUILD.bazel b/packages/angular/cli/BUILD.bazel index 030b92e1dbec..966b2d190356 100644 --- a/packages/angular/cli/BUILD.bazel +++ b/packages/angular/cli/BUILD.bazel @@ -69,7 +69,6 @@ ts_project( "//:node_modules/@types/yarnpkg__lockfile", "//:node_modules/listr2", "//:node_modules/semver", - "//:node_modules/symbol-observable", ], ) diff --git a/packages/angular/cli/lib/init.ts b/packages/angular/cli/lib/init.ts index 1bcd8fdca3b9..cd324b6df69b 100644 --- a/packages/angular/cli/lib/init.ts +++ b/packages/angular/cli/lib/init.ts @@ -6,8 +6,6 @@ * found in the LICENSE file at https://angular.dev/license */ -import 'symbol-observable'; -// symbol polyfill must go first import { readFile } from 'node:fs/promises'; import { createRequire } from 'node:module'; import * as path from 'node:path'; diff --git a/packages/angular/cli/package.json b/packages/angular/cli/package.json index a5b548b7da34..569e1b0806af 100644 --- a/packages/angular/cli/package.json +++ b/packages/angular/cli/package.json @@ -37,7 +37,6 @@ "pacote": "20.0.0", "resolve": "1.22.10", "semver": "7.7.1", - "symbol-observable": "4.0.0", "yargs": "17.7.2" }, "ng-update": { diff --git a/packages/angular_devkit/architect_cli/package.json b/packages/angular_devkit/architect_cli/package.json index c7ae69c92df6..1f368de6a504 100644 --- a/packages/angular_devkit/architect_cli/package.json +++ b/packages/angular_devkit/architect_cli/package.json @@ -18,7 +18,6 @@ "@angular-devkit/core": "workspace:0.0.0-PLACEHOLDER", "ansi-colors": "4.1.3", "progress": "2.0.3", - "symbol-observable": "4.0.0", "yargs-parser": "21.1.1" }, "devDependencies": { diff --git a/packages/angular_devkit/schematics_cli/BUILD.bazel b/packages/angular_devkit/schematics_cli/BUILD.bazel index fae06e0afb2a..26c63aff940d 100644 --- a/packages/angular_devkit/schematics_cli/BUILD.bazel +++ b/packages/angular_devkit/schematics_cli/BUILD.bazel @@ -52,7 +52,6 @@ ts_project( "//:node_modules/@types/node", "//:node_modules/@types/yargs-parser", "//:node_modules/ansi-colors", - "//:node_modules/symbol-observable", "//:node_modules/yargs-parser", ], ) diff --git a/packages/angular_devkit/schematics_cli/bin/schematics.ts b/packages/angular_devkit/schematics_cli/bin/schematics.ts index 5dab4733c13f..93e1ddbf9181 100644 --- a/packages/angular_devkit/schematics_cli/bin/schematics.ts +++ b/packages/angular_devkit/schematics_cli/bin/schematics.ts @@ -7,8 +7,6 @@ * found in the LICENSE file at https://angular.dev/license */ -// symbol polyfill must go first -import 'symbol-observable'; import { JsonValue, logging, schema } from '@angular-devkit/core'; import { ProcessOutput, createConsoleLogger } from '@angular-devkit/core/node'; import { UnsuccessfulWorkflowExecution } from '@angular-devkit/schematics'; diff --git a/packages/angular_devkit/schematics_cli/package.json b/packages/angular_devkit/schematics_cli/package.json index 480618ddb5ad..551ea58ccf1b 100644 --- a/packages/angular_devkit/schematics_cli/package.json +++ b/packages/angular_devkit/schematics_cli/package.json @@ -20,7 +20,6 @@ "@angular-devkit/schematics": "workspace:0.0.0-PLACEHOLDER", "@inquirer/prompts": "7.4.0", "ansi-colors": "4.1.3", - "symbol-observable": "4.0.0", "yargs-parser": "21.1.1" } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 693b7f17ddc0..06d228e663ad 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -281,9 +281,6 @@ importers: source-map-support: specifier: 0.5.21 version: 0.5.21 - symbol-observable: - specifier: 4.0.0 - version: 4.0.0 tar: specifier: ^7.0.0 version: 7.4.3 @@ -492,9 +489,6 @@ importers: semver: specifier: 7.7.1 version: 7.7.1 - symbol-observable: - specifier: 4.0.0 - version: 4.0.0 yargs: specifier: 17.7.2 version: 17.7.2 @@ -565,9 +559,6 @@ importers: progress: specifier: 2.0.3 version: 2.0.3 - symbol-observable: - specifier: 4.0.0 - version: 4.0.0 yargs-parser: specifier: 21.1.1 version: 21.1.1 @@ -843,9 +834,6 @@ importers: ansi-colors: specifier: 4.1.3 version: 4.1.3 - symbol-observable: - specifier: 4.0.0 - version: 4.0.0 yargs-parser: specifier: 21.1.1 version: 21.1.1 @@ -7191,10 +7179,6 @@ packages: resolution: {integrity: sha512-ot0WnXS9fgdkgIcePe6RHNk1WA8+muPa6cSjeR3V8K27q9BB1rTE3R1p7Hv0z1ZyAc8s6Vvv8DIyWf681MAt0w==} engines: {node: '>= 0.4'} - symbol-observable@4.0.0: - resolution: {integrity: sha512-b19dMThMV4HVFynSAM1++gBHAbk2Tc/osgLIBZMKsyqh34jb2e8Os7T6ZW/Bt3pJFdBTd2JwAnAAEQV7rSNvcQ==} - engines: {node: '>=0.10'} - table-layout@4.1.1: resolution: {integrity: sha512-iK5/YhZxq5GO5z8wb0bY1317uDF3Zjpha0QFFLA8/trAoiLbQD0HUbMesEaxyzUgDxi2QlcbM8IvqOlEjgoXBA==} engines: {node: '>=12.17'} @@ -15134,8 +15118,6 @@ snapshots: supports-preserve-symlinks-flag@1.0.0: {} - symbol-observable@4.0.0: {} - table-layout@4.1.1: dependencies: array-back: 6.2.2