From 5a5e047eb6b7ace2b558a95321b46a12d635a42d Mon Sep 17 00:00:00 2001 From: cexbrayat Date: Mon, 19 May 2025 18:00:54 +0200 Subject: [PATCH] fix(@schematics/angular): use protected for class member This follows the updated style guide recommendations. https://next.angular.dev/style-guide#use-protected-on-class-members-that-are-only-used-by-a-components-template --- .../files/module-files/src/app/app.spec.ts.template | 6 ------ .../application/files/module-files/src/app/app.ts.template | 2 +- .../files/standalone-files/src/app/app.spec.ts.template | 6 ------ .../files/standalone-files/src/app/app.ts.template | 2 +- 4 files changed, 2 insertions(+), 14 deletions(-) diff --git a/packages/schematics/angular/application/files/module-files/src/app/app.spec.ts.template b/packages/schematics/angular/application/files/module-files/src/app/app.spec.ts.template index e3f5c5fff092..43a982f1f3b1 100644 --- a/packages/schematics/angular/application/files/module-files/src/app/app.spec.ts.template +++ b/packages/schematics/angular/application/files/module-files/src/app/app.spec.ts.template @@ -22,12 +22,6 @@ describe('App', () => { expect(app).toBeTruthy(); }); - it(`should have as title '<%= name %>'`, () => { - const fixture = TestBed.createComponent(App); - const app = fixture.componentInstance; - expect(app.title).toEqual('<%= name %>'); - }); - it('should render title', () => { const fixture = TestBed.createComponent(App); fixture.detectChanges(); diff --git a/packages/schematics/angular/application/files/module-files/src/app/app.ts.template b/packages/schematics/angular/application/files/module-files/src/app/app.ts.template index ca94fc7bb99a..a7de7291cb3c 100644 --- a/packages/schematics/angular/application/files/module-files/src/app/app.ts.template +++ b/packages/schematics/angular/application/files/module-files/src/app/app.ts.template @@ -15,5 +15,5 @@ import { Component } from '@angular/core'; styleUrl: './app.<%= style %>'<% } %> }) export class App { - title = '<%= name %>'; + protected title = '<%= name %>'; } diff --git a/packages/schematics/angular/application/files/standalone-files/src/app/app.spec.ts.template b/packages/schematics/angular/application/files/standalone-files/src/app/app.spec.ts.template index eb529a1df3c7..808723635d96 100644 --- a/packages/schematics/angular/application/files/standalone-files/src/app/app.spec.ts.template +++ b/packages/schematics/angular/application/files/standalone-files/src/app/app.spec.ts.template @@ -16,12 +16,6 @@ describe('App', () => { expect(app).toBeTruthy(); }); - it(`should have the '<%= name %>' title`, () => { - const fixture = TestBed.createComponent(App); - const app = fixture.componentInstance; - expect(app.title).toEqual('<%= name %>'); - }); - it('should render title', () => { const fixture = TestBed.createComponent(App); fixture.detectChanges(); diff --git a/packages/schematics/angular/application/files/standalone-files/src/app/app.ts.template b/packages/schematics/angular/application/files/standalone-files/src/app/app.ts.template index 74ea464e5d04..ec40bb8c0c07 100644 --- a/packages/schematics/angular/application/files/standalone-files/src/app/app.ts.template +++ b/packages/schematics/angular/application/files/standalone-files/src/app/app.ts.template @@ -16,5 +16,5 @@ import { RouterOutlet } from '@angular/router';<% } %> styleUrl: './app.<%= style %>'<% } %> }) export class App { - title = '<%= name %>'; + protected title = '<%= name %>'; }