build: update dependency rules_nodejs to v6.6.0 #31557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See associated pull request for more information. Closes angular#31552 as a pr takeover
alan-agius4
added
action: merge
angular-robot
bot
added
the
area: build & ci
alan-agius4
commented
Oct 22, 2025
| package_json = "package.json", | ||
| ) | ||
|
|
||
| # This is needed following https://github.com/bazel-contrib/rules_nodejs/pull/3859 |
Collaborator
Author
There was a problem hiding this comment.
For context here's the error
INFO: ToolchainResolution: Performing resolution of @@rules_nodejs~//nodejs:toolchain_type for target platform //tools:windows_x64
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_linux_amd64//:toolchain; mismatching values: linux
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_linux_arm64//:toolchain; mismatching values: linux, aarch64
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_linux_s390x//:toolchain; mismatching values: linux, s390x
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_linux_ppc64le//:toolchain; mismatching values: linux, ppc
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_darwin_amd64//:toolchain; mismatching values: osx
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_darwin_arm64//:toolchain; mismatching values: osx, aarch64
ToolchainResolution: Toolchain @@rules_nodejs~~node~nodejs_windows_amd64//:toolchain is compatible with target plaform, searching for execution platforms:
ToolchainResolution: Incompatible execution platform @@platforms//host:host; mismatching values: windows
ToolchainResolution: Rejected toolchain @@rules_nodejs~~node~nodejs_windows_arm64//:toolchain; mismatching values: aarch64
ToolchainResolution: No @@rules_nodejs~//nodejs:toolchain_type toolchain found for target platform //tools:windows_x64.
Collaborator
Author
|
@josephperrott, is there a more elegant way of doing this? |
alan-agius4
added
action: review
Member
|
@alan-agius4 I don't think there is really a better way of doing this. Bazel modules don't allow macros so it just all has to be very explicit. I wish they would have set up the runtime toolchains to be part of an extension, but I haven't dove in enough to know if there is a very obvious reason why we can't do that. |
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #31552 as a pr takeover