test(@angular/build): add test with 'vitest' import in browser mode

[yjaaidi]

This fixes the following error:
'The entry point "vitest" cannot be marked as external'

by excluding vitest from the discovered dependencies handed to optimizeDeps.include

Closes #31745

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: #31745

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[yjaaidi]

Should I add a comment here?

I think that ideally, we should filter out all entrypoints from explicitBrowser but I can't imagine any valid scenario other then the vitest package import.

[yjaaidi]

Given we really need to run in browser mode to reproduce the bug, I had to install the packages so I went with an e2e.

Any narrower test would be over-specifying and not provide enough confidence.

[yjaaidi]

I'm AFK, I guess that I just have to explicitly choose headless.
I'll do this later

[clydin]

This was fixed via #31781 as now only implicit external packages are included of which vitest is not.

The root cause is that Vitest is making a variety changes to the optimizeDeps option internally for browser mode. One of which was adding vitest to entries which then caused an issue if vitest was also added to includes. Oddly, it also appears to add it to excludes which one may assume would take priority over an includes element.

An additional test case would still be useful though.

[yjaaidi]

This was fixed via #31781 as now only implicit external packages are included of which vitest is not.

The root cause is that Vitest is making a variety changes to the optimizeDeps option internally for browser mode. One of which was adding vitest to entries which then caused an issue if vitest was also added to includes. Oddly, it also appears to add it to excludes which one may assume would take priority over an includes element.

An additional test case would still be useful though.

Ah perfect! I saw the PR later and I was about to give it a try to see if it fixes it.
Oh! I remember the excludes gotcha. I remember scratching my head recently on it 😅

[hybrist]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 7206032
• 21.0.x: 8d63d59