Skip to content

fix(@angular/build): allow globals to be set to false #31786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
+35 −2
Merged

fix(@angular/build): allow globals to be set to false #31786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ function createTestBedInitVirtualFile(
import { NgModule${usesZoneJS ? ', provideZoneChangeDetection' : ''} } from '@angular/core';
import { getTestBed, ɵgetCleanupHook as getCleanupHook } from '@angular/core/testing';
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
import { afterEach, beforeEach } from 'vitest';
${providersImport}

const ANGULAR_TESTBED_SETUP = Symbol.for('@angular/cli/testbed-setup');
Expand Down
36 changes: 34 additions & 2 deletions packages/angular/build/src/builders/unit-test/tests/behavior/runner-config-vitest_spec.ts
View file
Open in desktop
Copy link
Contributor Author

@yjaaidi yjaaidi Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was not passing for the good reasons.
The result.success was false because the init env virtual file was failing.

Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
expect(results.numPassedTests).toBe(1);
});

it('should allow overriding builder options via runnerConfig file', async () => {
it('should allow overriding globals to false via runnerConfig file', async () => {
harness.useTarget('test', {
...BASE_OPTIONS,
runnerConfig: 'vitest.config.ts',
Expand All @@ -111,7 +111,7 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
harness.writeFile(
'src/app/app.component.spec.ts',
`
import { vi, test, expect } from 'vitest';
import { expect } from 'vitest';
test('should pass', () => {
expect(true).toBe(true);
});
Expand All @@ -122,6 +122,38 @@ describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
expect(result?.success).toBeFalse();
});

it('should initialize environment even when globals are disabled in runnerConfig file', async () => {
harness.useTarget('test', {
...BASE_OPTIONS,
runnerConfig: 'vitest.config.ts',
});

harness.writeFile(
'vitest.config.ts',
`
import { defineConfig } from 'vitest/config';
export default defineConfig({
test: {
globals: false,
},
});
`,
);

harness.writeFile(
'src/app/app.component.spec.ts',
`
import { test, expect } from 'vitest';
test('should pass', () => {
expect(true).toBe(true);
});
`,
);

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
});

it('should fail when a DOM-dependent test is run in a node environment', async () => {
harness.useTarget('test', {
...BASE_OPTIONS,
Expand Down