fix(@angular/build): enable test isolation by default in browser mode #31795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables test isolation by default when running tests in a browser. Disabling test isolation in browser mode has been found to cause non-deterministic test failures. To improve reliability, this change conditionally enables the `isolate` option when a browser provider is active. Isolation remains disabled for DOM emulation environments to maintain alignment with the traditional Karma/Jasmine experience. Further investigation is needed to determine if isolation can be safely disabled for browser mode in the future.
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables test isolation by default when running tests in a browser.
Disabling test isolation in browser mode has been found to cause non-deterministic test failures. To improve reliability, this change conditionally enables the
isolateoption when a browser provider is active.Isolation remains disabled for DOM emulation environments to maintain alignment with the traditional Karma/Jasmine experience. Further investigation is needed to determine if isolation can be safely disabled for browser mode in the future.