Skip to content

fix(@angular/build): enable test isolation by default in browser mode #31795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/build): enable test isolation by default in browser mode #31795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/angular/build/src/builders/unit-test/runners/vitest/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,9 @@ export async function createVitestConfigPlugin(
test: {
setupFiles,
globals: true,
// Default to `false` to align with the Karma/Jasmine experience.
isolate: false,
// Default to `false` to align with the Karma/Jasmine experience when using DOM emulation
// TODO: Investigate how this can be the default for browser mode as well
isolate: !!browser?.enabled,
sequence: { setupFiles: 'list' },
},
optimizeDeps: {
Expand Down