Skip to content

test: stabilize Vitest snapshot E2E test on Windows #31796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

test: stabilize Vitest snapshot E2E test on Windows #31796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions tests/legacy-cli/e2e/tests/vitest/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ng } from '../../utils/process';
import { appendToFile, replaceInFile, readFile } from '../../utils/fs';
import { replaceInFile, readFile, writeFile } from '../../utils/fs';
import { applyVitestBuilder } from '../../utils/vitest';
import assert from 'node:assert/strict';
import { stripVTControlCharacters } from 'node:util';
Expand All @@ -9,23 +9,32 @@ export default async function () {
await applyVitestBuilder();

// Add snapshot assertions to the test file
await appendToFile(
await replaceInFile(
'src/app/app.spec.ts',
`describe('App', () => {`,
`
it('should match file snapshot', () => {
const fixture = TestBed.createComponent(App);
const app = fixture.componentInstance;
expect((app as any).title()).toMatchSnapshot();
});
describe('App', () => {
it('should match file snapshot', () => {
const fixture = TestBed.createComponent(App);
const app = fixture.componentInstance;
expect((app as any).title()).toMatchSnapshot();
});

it('should match inline snapshot', () => {
const fixture = TestBed.createComponent(App);
const app = fixture.componentInstance;
expect((app as any).title()).toMatchInlineSnapshot();
});
`,
it('should match inline snapshot', () => {
const fixture = TestBed.createComponent(App);
const app = fixture.componentInstance;
expect((app as any).title()).toMatchInlineSnapshot();
});
`,
);

// Synchronize line endings for Vitest which currently may miscalculate line counts
// with mixed file line endings.
let content = await readFile('src/app/app.spec.ts');
content = content.replace(/\r\n/g, '\n');
content = content.replace(/\r/g, '\n');
await writeFile('src/app/app.spec.ts', content);

// First run: create snapshots
const { stdout: firstRunStdout } = await ng('test');
assert.match(
Expand All @@ -44,7 +53,7 @@ export default async function () {
const snapshotContent = await readFile('src/app/__snapshots__/app.spec.ts.snap');
assert.match(
snapshotContent,
/exports\[`should match file snapshot 1`\] = `"test-project"`;/,
/exports\[`App > should match file snapshot 1`\] = `"test-project"`;/,
'File snapshot was not written to disk.',
);

Expand Down