Skip to content

test: improve vitest e2e test stability and performance #31843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Nov 17, 2025
+47 −24
Merged

test: improve vitest e2e test stability and performance #31843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/angular/build/src/builders/unit-test/runners/vitest/browser-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,21 @@ export async function setupBrowserConfiguration(
// Validate that the imported module has the expected structure
const providerFactory = providerModule[providerName];
if (typeof providerFactory === 'function') {
provider = providerFactory();
if (
providerName === 'playwright' &&
process.env['CHROME_BIN']?.includes('rules_browsers')
) {
// Use the Chrome binary from the 'rules_browsers' toolchain (via CHROME_BIN)
// for Playwright when available to ensure hermetic testing, preventing reliance
// on locally installed or NPM-managed browser versions.
provider = providerFactory({
launchOptions: {
executablePath: process.env.CHROME_BIN,
},
});
} else {
provider = providerFactory();
}
} else {
errors ??= [];
errors.push(
Expand Down
52 changes: 31 additions & 21 deletions tests/legacy-cli/e2e/tests/vitest/larger-project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,7 @@ export default async function () {
// Each generated artifact will add one more test file.
const initialTestCount = 1;

// Generate a mix of components, services, and pipes
for (let i = 0; i < artifactCount; i++) {
const type = i % 3;
const name = `test-artifact-${i}`;
let generateType;

switch (type) {
case 0:
generateType = 'component';
break;
case 1:
generateType = 'service';
break;
default:
generateType = 'pipe';
break;
}

await ng('generate', generateType, name, '--skip-tests=false');
}
await generateArtifactsInBatches(artifactCount);

const totalTests = initialTestCount + artifactCount;
const expectedMessage = new RegExp(`${totalTests} passed`);
Expand All @@ -43,7 +24,6 @@ export default async function () {
// Setup for browser mode
await installPackage('playwright@1');
await installPackage('@vitest/browser-playwright@4');
await exec('npx', 'playwright', 'install', 'chromium', '--only-shell');

// Run tests in browser mode
const { stdout: browserStdout } = await ng(
Expand All @@ -58,3 +38,33 @@ export default async function () {
`Expected ${totalTests} tests to pass in browser mode.`,
);
}

async function generateArtifactsInBatches(artifactCount: number): Promise<void> {
Copy link
Collaborator Author

@alan-agius4 alan-agius4 Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running this locally I noticed that it was rather slow, so I went ahead and added batching.

const BATCH_SIZE = 5;
let commands: Promise<any>[] = [];

for (let i = 0; i < artifactCount; i++) {
const type = i % 3;
const name = `test-artifact-${i}`;
let generateType: string;

switch (type) {
case 0:
generateType = 'component';
break;
case 1:
generateType = 'service';
break;
default:
generateType = 'pipe';
break;
}

commands.push(ng('generate', generateType, name, '--skip-tests=false'));

if (commands.length === BATCH_SIZE || i === artifactCount - 1) {
await Promise.all(commands);
commands = [];
}
}
}
3 changes: 1 addition & 2 deletions tests/legacy-cli/e2e/tests/vitest/tslib-resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import { writeFile } from '../../utils/fs';
import { installPackage } from '../../utils/packages';
import { exec, ng } from '../../utils/process';
import { ng } from '../../utils/process';
import { applyVitestBuilder } from '../../utils/vitest';
import assert from 'node:assert';

export default async function () {
await applyVitestBuilder();
await installPackage('playwright@1');
await installPackage('@vitest/browser-playwright@4');
await exec('npx', 'playwright', 'install', 'chromium', '--only-shell');

// Add a custom decorator to trigger tslib usage
await writeFile(
Expand Down