Skip to content

Conversation

@mitsuruog
Copy link
Collaborator

@mitsuruog mitsuruog commented Aug 10, 2016

@laco0416 please review me.
このPRの内容は次の通りです。

トグル機能はこんな感じで動きます。

8 -10-2016 17-10-43

@lacolaco
Copy link
Collaborator

コミットメッセージをconventional-changelogのangular formatに合わせてもらえますか?

https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit

これを読んでもらうと良いと思います。
今回のコミットだと、

  • chore: 英語トグル機能を追加
  • chore: 翻訳のサンプルを追加

という感じでよいです

@lacolaco
Copy link
Collaborator

rebaseしてsquashしてもらったほうがいいかもです

  • chore: 英語トグル機能を追加

だけでよさそうに思えます

@mitsuruog mitsuruog force-pushed the feature/enable-english-toggle branch from cc0a8d0 to 586d5a9 Compare August 10, 2016 08:38
@mitsuruog
Copy link
Collaborator Author

@laco0416 please review again.

@lacolaco
Copy link
Collaborator

Thx!

@lacolaco lacolaco merged commit 4dcb684 into angular:master Aug 10, 2016
lacolaco added a commit that referenced this pull request Nov 21, 2025
* feat(ci): add untranslated files tracking issue automation

- Add --json flag to tools/list-untranslated.ts
- Create GitHub Actions workflow for automatic issue updates
- Implement issue update script with category grouping
- Add pre-filled issue creation links for each file

* chore: trigger workflow

* fix(ci): pin actions to commit SHAs

* fix(ci): suppress pnpm output in JSON parsing

* fix(ci): convert script to ESM format

* fix(ci): use absolute path for ESM import

* fix(ci): use npx tsx directly to avoid pnpm output

* chore(ci): update issue title and remove feature branch trigger

* chore(ci): re-add feature branch trigger for testing

* docs(ci): add JSDoc type annotations to sync script

* style(ci): remove bold formatting from file names

* fix(ci): update existing issue with new title and format

* chore(ci): remove backward compatibility for old issue title

* feat(ci): open preview links in new tab

* revert: remove target=_blank from preview links

* feat(tools): exclude tutorial config.json from untranslated list

* feat(ci): add Tools category to untranslated files list

* feat(ci): add Ecosystem category to untranslated files list

* feat(ci): integrate Translation Checkout issues with tracking list

* test: trigger workflow to verify Translation Checkout integration

* test: verify Translation Checkout integration with Issue #5

* fix: use prefix matching for Translation Checkout issues to support directory declarations

* fix: use simple #{num} format for issue links and remove feature branch trigger

* test: re-add feature branch trigger for final verification

* chore: remove feature branch trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants