Move controllers inside phonecat module #27

Closed
DavidSouther opened this Issue Oct 11, 2012 · 1 comment

Comments

Projects
None yet
2 participants

Leaving the controllers in global scope just seems like very bad practice, and likely encourages terrible code for people following the tutorial to learn Angular. It just looks really bad. Worse, the tests depend on this behavior, making the tutorial useless for trying to figure out how to write unit tests that load just the components needed for testing.

Member

petebacondarwin commented Oct 23, 2013

This has now been remedied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment