Skip to content

Fix navigateTo() links to work with routing settings. #22

wants to merge 17 commits into from

2 participants


At least in Chrome 21.0.1180.15 beta, the explicit mention of index.html in the URLs for navigateTo() will not work in the e2e test as the route just won't route and thus ignores the specified URL fragment. Just tossing index.html and relying on the directory name is enough to make the tests pass again.

IgorMinar and others added some commits Mar 5, 2011
@IgorMinar IgorMinar angular-phonecat
added phonecat specific info into the file
@IgorMinar IgorMinar add bootstrap 2.0.3 42aa2af
@IgorMinar IgorMinar add reset flag to jstd to prevent lameness 9b48cbe
@IgorMinar IgorMinar add tutorial related scripts b6eddbb
@IgorMinar IgorMinar add phones.json
- Added a json file with a list of all phones. This file fakes a
  backend which would typically render this list dynamically from
  a database.
@IgorMinar IgorMinar add phone detail json files
- Added one json file with detailed information about each phone
  listed in phones.json
@IgorMinar IgorMinar add phone images
- Added images for each phone listed in phones.json
@IgorMinar IgorMinar empty the angular-seed project
- Initial [angular-seed] project layout without default app and test
@IgorMinar IgorMinar step-0 bootstrap angular app
- add ngApp directive to bootstrap the app
- add simple template with an expression
@IgorMinar IgorMinar step-1 static phone list
- Added static html list with two phones into index.html
@IgorMinar IgorMinar step-2 angular template with repeater
- Converted the static html list into dynamic one by:
  - creating PhoneListCtrl controller for the application
  - extracting the data from HTML into a the controller as an in-memory
  - converting the static document into a template with the use of
    `[ngRepeat]` [directive] which iterates over the dataset with phones,
    clones the ngRepeat template for each instance and renders it into the
- Added a simple unit test to show off how to write tests and run them
  with JsTD (see for instructions)
@IgorMinar IgorMinar step-3 interactive search
- Added a search box to demonstrate how:
  - the data-binding works on input fields
  - to use [filter] filter
  - [ngRepeat] automatically shrinks and grows the number of phones in the view
- Added an end-to-end test to:
  - show how end-to-end tests are written and used
  - to prove that the search box and the repeater are correctly wired together
@IgorMinar IgorMinar step-5 XHR and dependency injection
- Replaced the in-memory dataset with data loaded from the server (in
  the form of static phone.json file to make this tutorial backend
  - The json file is loaded using the [$http] service
- Demonstrate the use of [services][service] and [dependency injection][DI]
  - The [$http] is injected into the controller through [dependency injection][DI]
@IgorMinar IgorMinar step-6 phone images and links
- adding phone image and links to phone pages
- add end2end test that verifies our phone links
- css to style the page just a notch
@IgorMinar IgorMinar step-4 phone ordering
- Add "age" property to the phone model
- Add select box to control phone list order
- Override the default order value in controller
- Add unit and e2e test for this feature
@IgorMinar IgorMinar step-7 $route and app partitioning
- Introduce the [$route] service which allows binding URLs for deep-linking with
  - Create PhoneCatCtrl which governs the entire app and contains $route
  - Map `/phones' to PhoneListCtrl and partails/phones-list.html
  - Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
  - Copy deep linking parameters to root controller `params` property for access
    in sub controllers
  - Replace content of index.html with [ng:view] widget
- Create phone list route
  - Preserve existing PhoneListCtrl controller
  - Move existing html from index.html to partials/phone-list.html
- Create phone details route
  - Empty placeholder PhoneDetailsCtrl controller
  - Empty placeholder partials/phane-details.html template
@brettcannon brettcannon Fix navigateTo() links to work with routing settings. 7deb1b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.